Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token): handle errors from msgback by creating a invalid token #194

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

rhizoome
Copy link

@rhizoome rhizoome commented Jul 3, 2023

old tokens cause a crash because they are valid branca tokens but do not contain valid message-pack data

manabi/token.py Outdated Show resolved Hide resolved
@rhizoome rhizoome marked this pull request as draft July 5, 2023 08:59
@rhizoome rhizoome marked this pull request as ready for review July 5, 2023 12:40
@winged
Copy link
Contributor

winged commented Jul 5, 2023

I like the typed exceptions much more! 🎉

@winged winged merged commit 1cae47f into projectcaluma:main Jul 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants