Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pre_write_callback and hook/callback approve write #185

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

rhizoome
Copy link

@rhizoome rhizoome commented Jun 21, 2023

If the API were unavailable and the version was not created, we prefer not to proceed with writing, as it would result in the loss of that particular version.

@rhizoome rhizoome changed the title feat: add pre_write_callback feat: add pre_write_callback and hook/callback approve write Jun 21, 2023
@rhizoome rhizoome requested a review from winged June 21, 2023 14:50
If the API were unavailable and the version was not created, we prefer not to
proceed with writing, as it would result in the loss of that particular
version.
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM!

@winged winged merged commit 11757f1 into projectcaluma:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants