Skip to content

Commit

Permalink
Fix that we don't produce a :latest tag
Browse files Browse the repository at this point in the history
  • Loading branch information
caseydavenport committed Jul 10, 2018
1 parent 587895a commit ef86294
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ clean:
# Delete images that we built in this repo
docker rmi $(NODE_CONTAINER_NAME):latest-$(ARCH) || true
docker rmi $(TEST_CONTAINER_NAME) || true
ifeq ($(ARCH),amd64)
docker rmi $(NODE_CONTAINER_NAME):latest || true
docker rmi $(NODE_CONTAINER_NAME):$(VERSION) || true
endif

# Retag and remove external images so that they will be pulled again
# We avoid just deleting the image. We didn't build them here so it would be impolite to delete it.
Expand Down Expand Up @@ -171,6 +175,9 @@ $(NODE_CONTAINER_CREATED): ./Dockerfile$(ARCHTAG) $(NODE_CONTAINER_FILES) $(addp
echo; echo confd --version; /go/bin/confd --version; \
"
docker build --pull -t $(NODE_CONTAINER_NAME):latest-$(ARCH) . --build-arg ver=$(CALICO_GIT_VER) -f ./Dockerfile$(ARCHTAG)
ifeq ($(ARCH),amd64)
docker tag $(NODE_CONTAINER_NAME):latest-$(ARCH) $(NODE_CONTAINER_NAME):latest
endif
touch $@

# Get felix binaries
Expand Down

0 comments on commit ef86294

Please sign in to comment.