support setting passive mode in bgp peer

[dqminh]

For projectcalico/calico#1603

This allow use to set passive: true in bgp peer spec so we can leverage that in calico/node to set proper bird config.

I think this should touches all the required place here. Then we would want to modify calico/node for confd config and calicoctl for updating new fields.

cc @caseydavenport

[CLAassistant]

All committers have signed the CLA.

[caseydavenport]

@dqminh thanks for this pr!

I think there's a bit more to do here. Namely, update the model.BGPeer to include this field (this is what confd sees)

Is there a corresponding PR for the BIRD templates? It would be good to review them together since they rely on each other.

Also, looks like the bot would like you to sign the CLA :)

[mattalberts]

@caseydavenport I've gone ahead and updated the PR with a change to model.BGPPeer.

Would it be worth modifying api.BGPPeer as well to allow filling in the full model.BGPPeer struct?

As a potentially unrelated side-note, how does back-porting a change work? We'll be migrating to 2.6.x; I just want to make certain this change would land there as well.

[caseydavenport]

As a potentially unrelated side-note, how does back-porting a change work? We'll be migrating to 2.6.x; I just want to make certain this change would land there as well.

So, we'll need to work through this one. Strictly speaking, this is an API change and so would require a minor bump rather than a patch release (e.g v2.7.0, or v3.2.0). I don't think we have any plans to cut a v2.7.0 release.

I'll need to discuss internally and get back to you, but in the absence of that I imagine this would land in v3.2.0.

[caseydavenport]

Looks like the fomatting check is failing, proabably need to run goimports over the new code.

You'll also need to run make gen-files to update some autogenerated code.

[mattalberts]

@caseydavenport sorry about that! I've let go imports fix the formatting (shame shame shame). I've also re-run gen-files; though, that only netted a change to deepcopy (the import order).

[caseydavenport]

This looks good to me.

Before we merge I'd like to be able to review it side-by-side with the corresponding confd template changes to make this work. Is there a PR for that as well?

[mattalberts]

There isn't one yet ... but ... I can make one! :)

[caseydavenport]

Any update on this guy?

[caseydavenport]

@mattalberts @dqminh this has gotten out of date and needs a rebase.

I'm going to close for now since there hasn't been any recent activity, but do ping me if you find time to work on this and we can reopen - I'd quite like to see it go in!