Use Amazon VPC annotation to get pod IPs, if set #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
force-pushed
the
casey-respect-aws-annotation
branch
3 times, most recently
from
11255a5 to
9f18417
Compare
fasaxc
reviewed
Oct 15, 2021
caseydavenport
force-pushed
the
casey-respect-aws-annotation
branch
from
9f18417 to
a52a875
Compare
|
Good catch - thanks @fasaxc Think this is ready for a final look |
fasaxc
approved these changes
Oct 18, 2021
caseydavenport
force-pushed
the
casey-respect-aws-annotation
branch
from
a52a875 to
0bebcbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still needs tests.
Corresponding PR to aws/amazon-vpc-cni-k8s#1629
Fixes projectcalico/calico#3530
Reference: kubernetes/kubernetes#39113
Todos
Release Note