New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.90] Add back push-manifests in Makefile #498

Merged

hjiawei merged 1 commit into projectcalico:v0.90 from hjiawei:fix-push-manifests-v0.90

Nov 22, 2023

Collaborator

hjiawei commented Nov 22, 2023

Reimplement push-manifests in Makefile.common using docker manifest command [1]. It was removed in [2]. This change is ported from [3].

[1] https://docs.docker.com/engine/reference/commandline/manifest/
[2] https://github.com/projectcalico/go-build/pull/490/files#diff-f190d29e2cad4f32539c8b73d8af07c77f0aac63b5c6553c06b117c08a70b494L876
[3] projectcalico/calico#8254

Pick #497 into v0.90 branch.


          Add back push-manifests in Makefile

fced0cf

Reimplement `push-manifests` in `Makefile.common` using
`docker manifest` command [1]. It was removed in [2]. This change is
ported from [3].

[1] https://docs.docker.com/engine/reference/commandline/manifest/
[2] https://github.com/projectcalico/go-build/pull/490/files#diff-f190d29e2cad4f32539c8b73d8af07c77f0aac63b5c6553c06b117c08a70b494L876
[3] projectcalico/calico#8254

hjiawei requested a review from rene-dekker

November 22, 2023 21:02

rene-dekker approved these changes

View reviewed changes

hjiawei merged commit 4b01e04 into projectcalico:v0.90

hjiawei deleted the fix-push-manifests-v0.90 branch

November 22, 2023 21:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet