Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.28] Auto pick #9192: traffic from host should return through host #9199

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented Aug 29, 2024

Cherry pick of #9192 on release-v3.28.

#9192: traffic from host should return through host

Original PR Body below

Anything that has not been seen bofore arriving on the WEP is clearly from the host and so we should return any responses through the host as well.

This also effectively disables conntrack bypass for traffic that is returning from a workload to a pod. This allow returning traffic to go through iptables rules that previously could have affected inbound traffic - similar rules like the ones inject by Istion in ambient mode.

fixes #9157

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: Fix for Istio ambient mode - traffic that arrives from host should go back through host and not skip iptables

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@tomastigera tomastigera requested a review from a team as a code owner August 29, 2024 18:50
@tomastigera tomastigera added release-note-required Change has user-facing impact (no matter how small) docs-not-required Docs not required for this change labels Aug 29, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.28.2 milestone Aug 29, 2024
Anything that has not been seen bofore arriving on the WEP is clearly
from the host and so we should return any responses through the host as
well.

This also effectively disables conntrack bypass for traffic that is
returning from a workload to a pod. This allow returning traffic to go
through iptables rules that previously could have affected inbound
traffic - similar rules like the ones inject by Istion in ambient mode.

fixes projectcalico#9157
@tomastigera tomastigera force-pushed the auto-pick-of-#9192-upstream-release-v3.28 branch from c94309c to dbfc576 Compare August 29, 2024 21:07
@tomastigera tomastigera merged commit 51e5a7e into projectcalico:release-v3.28 Aug 30, 2024
2 of 3 checks passed
@tomastigera tomastigera deleted the auto-pick-of-#9192-upstream-release-v3.28 branch August 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants