BGPFilter: Add prefixLength to BGPFilter to match on min/max prefix length #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
mstansberry
changed the title
bsalmicw
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Thanks for picking this up @mstansberry !
It's looking pretty good - most of my comments are just API conventions type stuff to make sure we have the right optionality set, and to ensure users can't provide invalid input on the API.
|
Just following up to see if there are any additional changes to make here? Thanks a lot. |
mstansberry
force-pushed
the
route_filter_prefix
branch
from
08ef030 to
1770836
Compare
caseydavenport
approved these changes
Aug 15, 2024
|
/sem-approve |
…ength BGPFilter: Update PrefixLength to use pointers, add validators, and move to int32 BGPFilter: Update BGPFilter tests to duplicate and only use ipv6 in v6 rules BGPFilter: Add test confirming prefixLength is ignored when CIDR is not provided BGPFilter: Add error surfacing for failed ParseCIDR BGPFilter: Add kubebuilder validation for PrefixLength BGPFilter: Flatten validator functions for PrefixLength and add checks for empty CIDR
mstansberry
force-pushed
the
route_filter_prefix
branch
from
1770836 to
154de3f
Compare
|
Removing "merge-when-ready" label due to new commits |
|
squashed based on the label applied, looks like that might have been the wrong move |
|
@mstansberry whoops! Sorry, that label is for the bot |
|
/sem-approve |
|
Just allows me to run CI, apply the label, and the bot will merge once it passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefixLengthto BGPFilter struct for more granular matchingRelated issues/PRs
fixes #8376
documents tigera/docs#1592
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.