Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.27] Auto pick #9022: Change rpm install order to fix 'undefined #9024

Conversation

coutinhop
Copy link
Member

Cherry pick of #9022 on release-v3.27.

#9022: Change rpm install order to fix 'undefined

Original PR Body below

microdnf install iproute-tc nftables would install iptables-libs 1.8.5-11.el8_9 as a dependency, and it provides /lib64/libxtables.so.12.3.0. When using that .so file with LD_PRELOAD, we can consistently reproduce the issue:

# LD_PRELOAD=/lib64/libxtables.so.12.3.0 iptables-legacy-save
iptables-legacy-save: symbol lookup error: iptables-legacy-save: undefined symbol: xtables_strdup

The problem was, during our build process, we build iptables (and iptables-libs) v1.8.8 and install with rpm --force, but that doesn´t remove the outdated v1.8.5. By moving things around in the Dockerfiles and installing iptables-libs 1.8.8 before iproute-tc and nftables, the problematic 1.8.5 package is no longer installed and thus the correct .so file should be used (libxtables.so.12.6.0 at the time of writing this).

Description

Related issues/PRs

fixes #8831 (tentatively, pending user confirmation)

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix 'undefined symbol: xtables_strdup' error when running 'iptables-legacy-save' in the calico-node image.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

`microdnf install iproute-tc nftables` would install `iptables-libs` 1.8.5-11.el8_9 as a dependency, and it provides `/lib64/libxtables.so.12.3.0`. When using that `.so` file with `LD_PRELOAD`, we can consistently reproduce the issue:

```
LD_PRELOAD=/lib64/libxtables.so.12.3.0 iptables-legacy-save
iptables-legacy-save: symbol lookup error: iptables-legacy-save: undefined symbol: xtables_strdup
```

The problem was, during our build process, we build iptables (and iptables-libs) v1.8.8 and install with `rpm --force`, but that doesn´t remove the outdated v1.8.5. By moving things around in the Dockerfiles and installing iptables-libs 1.8.8 before iproute-tc and nftables, the problematic 1.8.5 package is no longer installed and thus the correct `.so` file should be used (`libxtables.so.12.6.0` at the time of writing this).
@coutinhop coutinhop requested a review from a team as a code owner July 18, 2024 01:23
@coutinhop coutinhop added release-note-required Change has user-facing impact (no matter how small) cherry-pick-candidate docs-not-required Docs not required for this change labels Jul 18, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.27.4 milestone Jul 18, 2024
@coutinhop coutinhop self-assigned this Jul 18, 2024
@coutinhop coutinhop merged commit cd3755e into projectcalico:release-v3.27 Jul 19, 2024
2 checks passed
@coutinhop coutinhop deleted the auto-pick-of-#9022-upstream-release-v3.27 branch July 19, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants