Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run pprof on prometheus port #8967

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Jul 2, 2024

Description

Fixes #8936

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Don't run pprof on prometheus metrics port 

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@caseydavenport caseydavenport requested a review from a team as a code owner July 2, 2024 16:32
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Jul 2, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jul 2, 2024
@caseydavenport caseydavenport added the docs-not-required Docs not required for this change label Jul 2, 2024
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label Jul 2, 2024
Copy link
Member

@fasaxc fasaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvin-tigera marvin-tigera merged commit 411d9c0 into projectcalico:master Jul 2, 2024
2 checks passed
@caseydavenport caseydavenport deleted the casey-fix-pprof branch July 2, 2024 17:26
coutinhop pushed a commit to coutinhop/calico that referenced this pull request Sep 13, 2024
coutinhop added a commit to coutinhop/calico that referenced this pull request Sep 16, 2024
Bump cni and flannel versions to use go v1.22.7

Use calicoctl v3.28 instead of master in node sts to avoid issue with tiers CRD

Merge pull request projectcalico#8967 from caseydavenport/casey-fix-pprof

Don't run pprof on prometheus port

Increase timeouts in service loop prevention tests to mititgate flakes
coutinhop added a commit that referenced this pull request Sep 16, 2024
Bump cni and flannel versions to use go v1.22.7

Use calicoctl v3.28 instead of master in node sts to avoid issue with tiers CRD

Merge pull request #8967 from caseydavenport/casey-fix-pprof

Don't run pprof on prometheus port

Increase timeouts in service loop prevention tests to mititgate flakes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-controllers: pprof is enabled on /metrics server port.
3 participants