Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.28] Auto pick #8922: set MTU on bpfin/out.cali to match host #8954

Conversation

tomastigera
Copy link
Contributor

Cherry pick of #8922 on release-v3.28.

#8922: set MTU on bpfin/out.cali to match host

Original PR Body below

Set the MTU to match the smallest MTU of the host devices as per the current autodetection. That makes sure that if large MTU is used, the extra device does not create a bottleneck with a small MTU. Also when MTU changes, on host devices, it get adjusted automatically. If an overlay is used, the special device MTU is adjusted to the size of the overlay.

Fixes #8868

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: set bpfin/out.cali MTU to the smallest of all host ifaces including overlay. That means if jumbo frames are used, this device also uses them.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Set the MTU to match the smallest MTU of the host devices as per the
current autodetection. That makes sure that if large MTU is used, the
extra device does not create a bottleneck with a small MTU. Also when
MTU changes, on host devices, it get adjusted automatically. If an
overlay is used, the special device MTU is adjusted to the size of the
overlay.

Fixes projectcalico#8918
@tomastigera tomastigera requested a review from a team as a code owner June 28, 2024 10:48
@tomastigera tomastigera added release-note-required Change has user-facing impact (no matter how small) cherry-pick-candidate docs-pr-required Change is not yet documented labels Jun 28, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.28.1 milestone Jun 28, 2024
@tomastigera
Copy link
Contributor Author

unrelated faiures fixed elsewhere

@tomastigera tomastigera merged commit cba36fd into projectcalico:release-v3.28 Jun 28, 2024
1 of 2 checks passed
@tomastigera tomastigera deleted the auto-pick-of-#8922-upstream-release-v3.28 branch June 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-candidate docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants