Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get the newest node configuration every poll interval when monitoring IP Address subnets #8728

Merged

Conversation

Levi080513
Copy link
Contributor

@Levi080513 Levi080513 commented Apr 18, 2024

Description

Try to get the newest node configuration every poll interval when monitoring IP Address subnets.

Related issues/PRs

#8700

Tests

  1. Current k8s node and IP.
NAME                                STATUS   ROLES    AGE   VERSION    INTERNAL-IP    EXTERNAL-IP   OS-IMAGE                           KERNEL-VERSION                 CONTAINER-RUNTIME
hw-sks-test-logging-logging-m9c27   Ready    <none>   44h   v1.25.15   10.255.2.134   <none>        Rocky Linux 8.8 (Green Obsidian)   4.18.0-477.27.1.el8_8.x86_64   containerd://1.6.22
  1. Modify the IP of k8s node by configuring static IP.
hw-sks-test-logging-logging-m9c27   Ready      <none>   44h   v1.25.15   10.255.2.135   <none>        Rocky Linux 8.8 (Green Obsidian)   4.18.0-477.27.1.el8_8.x86_64   containerd://1.6.22
  1. monitor-addresses log show ip changed and updated
2024-04-18 15:32:05.741 [INFO][76] monitor-addresses/autodetection_methods.go 229: Including CIDR information from host interface. CIDR="10.255.2.135/16"
2024-04-18 15:32:05.742 [INFO][76] monitor-addresses/startup.go 579: Node IPv4 changed, will check for conflicts
2024-04-18 15:32:05.767 [WARNING][76] monitor-addresses/startup.go 1004: IPv4 address has changed. This could happen if there are multiple nodes with the same name. node="hw-sks-test-logging-logging-m9c27" original="10.255.2.134" updated="10.255.2.135"
2024-04-18 15:32:05.808 [INFO][76] monitor-addresses/startup.go 372: Updated node IP addresses
2024-04-18 15:33:05.864 [INFO][76] monitor-addresses/autodetection_methods.go 229: Including CIDR information from host interface. CIDR="10.255.2.135/16"

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix that Calico would ignore changes to Kubernetes Node InternalIP when using InternalIP node address autodetection.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@Levi080513 Levi080513 requested a review from a team as a code owner April 18, 2024 07:38
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Apr 18, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 18, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport
Copy link
Member

/sem-approve

@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport merged commit b833a53 into projectcalico:master Apr 25, 2024
2 checks passed
@Levi080513
Copy link
Contributor Author

@caseydavenport Can this PR be cherry-picked to 3.26.x?

@caseydavenport
Copy link
Member

@Levi080513 I think that's fine, but I am not sure if / when we'll do another v3.26 patch release - we're about to release v3.29 which would put v3.26 largely out of schedule for patches.

@Levi080513
Copy link
Contributor Author

Well, then I'll wait for release v3.29.

@coutinhop coutinhop added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants