-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BPF] wg6 traffic is allowed even if blocked by policy #8712
Merged
tomastigera
merged 5 commits into
projectcalico:master
from
tomastigera:tomas-bpf-wg6-fv
Apr 25, 2024
Merged
[BPF] wg6 traffic is allowed even if blocked by policy #8712
tomastigera
merged 5 commits into
projectcalico:master
from
tomastigera:tomas-bpf-wg6-fv
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a misconfiguration as wg6 may/likely have different listening port than wg. So the right config value needs to be set. wg6 fv tests are enabled.
marvin-tigera
added
release-note-required
Change has user-facing impact (no matter how small)
docs-pr-required
Change is not yet documented
labels
Apr 10, 2024
tomastigera
added
docs-not-required
Docs not required for this change
and removed
docs-pr-required
Change is not yet documented
labels
Apr 10, 2024
sridhartigera
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge-when-ready |
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
Removing "merge-when-ready" label due to new commits |
tomastigera
force-pushed
the
tomas-bpf-wg6-fv
branch
from
April 23, 2024 20:34
1401ca3
to
eb44d2f
Compare
Also less shell outs
tomastigera
force-pushed
the
tomas-bpf-wg6-fv
branch
from
April 23, 2024 22:45
eb44d2f
to
6755587
Compare
3 tasks
tomastigera
added a commit
that referenced
this pull request
Apr 25, 2024
…-release-v3.28 [release-v3.28] Auto pick #8712: wg6 traffic is allowed even if blocked by policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-candidate
docs-not-required
Docs not required for this change
release-note-required
Change has user-facing impact (no matter how small)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a misconfiguration as wg6 may/likely have different listening port than wg. So the right config value needs to be set.
Also all v4 iptables rules are now rendered in dual stack mode.
wg6 fv tests are enabled.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.