Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] wg6 traffic is allowed even if blocked by policy #8712

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented Apr 10, 2024

This fixes a misconfiguration as wg6 may/likely have different listening port than wg. So the right config value needs to be set.

Also all v4 iptables rules are now rendered in dual stack mode.

wg6 fv tests are enabled.

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: wg6 traffic is allowed even if blocked by policy

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

This fixes a misconfiguration as wg6 may/likely have different listening
port than wg. So the right config value needs to be set.

wg6 fv tests are enabled.
@tomastigera tomastigera requested a review from a team as a code owner April 10, 2024 22:03
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Apr 10, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 10, 2024
@tomastigera tomastigera added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Apr 10, 2024
Copy link
Member

@sridhartigera sridhartigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomastigera
Copy link
Contributor Author

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

@tomastigera tomastigera merged commit d3a7da7 into projectcalico:master Apr 25, 2024
2 checks passed
@tomastigera tomastigera deleted the tomas-bpf-wg6-fv branch April 25, 2024 03:57
tomastigera added a commit that referenced this pull request Apr 25, 2024
…-release-v3.28

[release-v3.28] Auto pick #8712: wg6 traffic is allowed even if blocked by policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-candidate docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants