-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eBPF: Update map definition in sockops program #8693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfp_map_def map declaration was deprecated https://github.com/libbpf/libbpf/wiki/Libbpf%3A-the-road-to-v1.0#drop-support-for-legacy-bpf-map-declaration-syntax
marvin-tigera
added
release-note-required
Change has user-facing impact (no matter how small)
docs-pr-required
Change is not yet documented
labels
Apr 4, 2024
debasishbsws
changed the title
Update as the older format was deprecated
Update as the older format bpf_map-def was deprecated
Apr 4, 2024
mazdakn
requested changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debasishbsws Thanks for finding and fixing this. We recently fixed the issue in PR #8610, but failed to catch this one.
/sem-approve |
mazdakn
approved these changes
Apr 8, 2024
sridhartigera
approved these changes
Apr 8, 2024
mazdakn
added a commit
to mazdakn/calico
that referenced
this pull request
Apr 8, 2024
Update as the older format bpf_map-def was deprecated
3 tasks
mazdakn
changed the title
Update as the older format bpf_map-def was deprecated
eBPF: Update map definition in sockops program
Apr 8, 2024
mazdakn
added a commit
to mazdakn/calico
that referenced
this pull request
Apr 8, 2024
Update as the older format bpf_map-def was deprecated
mazdakn
added a commit
to mazdakn/calico
that referenced
this pull request
Apr 8, 2024
Update as the older format bpf_map-def was deprecated
3 tasks
mazdakn
added a commit
to mazdakn/calico
that referenced
this pull request
May 16, 2024
Update as the older format bpf_map-def was deprecated
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-not-required
Docs not required for this change
release-note-required
Change has user-facing impact (no matter how small)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bpf_map_def map declaration was deprecated https://github.com/libbpf/libbpf/wiki/Libbpf%3A-the-road-to-v1.0#drop-support-for-legacy-bpf-map-declaration-syntax
was getting errors while building from the source for Wolfi
Release Note