Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary FIPS code #8538

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

rene-dekker
Copy link
Contributor

@rene-dekker rene-dekker commented Feb 21, 2024

The FIPS_ENABLED flags precede building with fips_strict mode. With the introduction of that flag, there is no point any longer of passing a bool into the NewTLSConfig() func.

Also, did some cleanup of the Makefile for the crypto suite.

@marvin-tigera marvin-tigera added this to the Calico v3.28.0 milestone Feb 21, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Feb 21, 2024
@rene-dekker rene-dekker force-pushed the EV-4698 branch 3 times, most recently from a0326cb to fd16e7f Compare February 21, 2024 01:14
@rene-dekker rene-dekker changed the title EV-4698 Remove unnecessary FIPS code. Run crypto tests containerized. EV-4698 Remove unnecessary FIPS code Feb 21, 2024
@rene-dekker rene-dekker marked this pull request as ready for review February 21, 2024 19:46
@rene-dekker rene-dekker requested a review from a team as a code owner February 21, 2024 19:46
crypto/Makefile Outdated Show resolved Hide resolved
@tomastigera tomastigera merged commit 45ecfc5 into projectcalico:master Feb 23, 2024
2 checks passed
@tomastigera tomastigera changed the title EV-4698 Remove unnecessary FIPS code Remove unnecessary FIPS code Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants