Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] ClusterIP should reflect InternalTrafficPolicy=Local #8259

Conversation

tomastigera
Copy link
Contributor

https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/

fixes #8255

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: ClusterIP reflects InternalTrafficPolicy=Local

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@marvin-tigera marvin-tigera added this to the Calico v3.28.0 milestone Nov 23, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 23, 2023
@tomastigera tomastigera added cherry-pick-candidate docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Nov 23, 2023
@tomastigera tomastigera marked this pull request as ready for review November 23, 2023 02:18
@tomastigera tomastigera requested a review from a team as a code owner November 23, 2023 02:18
Copy link
Member

@sridhartigera sridhartigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already handling InternalPolicyLocal and ExternalPolicyLocal for services such as nodeport, LB and externalIP. Hence I feel this change must be for clusterIP alone.

felix/bpf/proxy/syncer.go Show resolved Hide resolved
@tomastigera tomastigera force-pushed the tomas-bpf-internal-traffic-policy-fix branch from 6bac8fc to 5678f07 Compare November 23, 2023 05:33
Copy link
Member

@fasaxc fasaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments; don't think I need to rereview

felix/bpf/nat/maps.go Outdated Show resolved Hide resolved
felix/fv/bpf_test.go Outdated Show resolved Hide resolved
@tomastigera tomastigera force-pushed the tomas-bpf-internal-traffic-policy-fix branch from 5678f07 to ad65c95 Compare November 23, 2023 18:08
Copy link
Member

@sridhartigera sridhartigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomastigera
Copy link
Contributor Author

only a flake when ctlb is not using aff map from felix-0

@tomastigera tomastigera merged commit 408246a into projectcalico:master Nov 23, 2023
1 of 2 checks passed
@tomastigera tomastigera deleted the tomas-bpf-internal-traffic-policy-fix branch November 23, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calico in eBPF mode ignores internalTrafficPolicy: Local
4 participants