Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v3.22] Auto pick #5498: felix/bpf: fix err handling in bpf_program_attach_cgroup #6056

Merged
merged 3 commits into from
May 11, 2022
Merged

[release-v3.22] Auto pick #5498: felix/bpf: fix err handling in bpf_program_attach_cgroup #6056

merged 3 commits into from
May 11, 2022

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented May 10, 2022 •
edited
Loading

Cherry pick of #5498 on release-v3.22.

#5498: felix/bpf: fix err handling in bpf_program_attach_cgroup

Original PR Body below

As the error is encoded in the link pointer, it it not NULL in case of
an error.

Description

Related issues/PRs

fixes #5957

refs #5979

refs #5775

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: fixed error handling in attaching cgroup (ctlb) programs with libbpf so that a fallback method is executed when the current method fails. Otherwise success is reported and ctlb programs are not loaded (fresh install) or old are not replaced (upon upgrade)

@tomastigera tomastigera requested a review from a team as a code owner May 10, 2022 21:10
@tomastigera tomastigera added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022 •
edited
Loading

✅ Deploy Preview for calico-tigera canceled.

Name Link
🔨 Latest commit 8f9072a
🔍 Latest deploy log https://app.netlify.com/sites/calico-tigera/deploys/627ad4e2b24c670008c558c9

@marvin-tigera marvin-tigera added this to the Calico v3.22.3 milestone May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022 •
edited
Loading

✅ Deploy Preview for calico-v3-22 canceled.

Name Link
🔨 Latest commit 8f9072a
🔍 Latest deploy log https://app.netlify.com/sites/calico-v3-22/deploys/627ad4e2289cb20008ce9d13

@caseydavenport caseydavenport added release-note-required Change has user-facing impact (no matter how small) merge-when-ready and removed release-note-not-required Change has no user-facing impact labels May 10, 2022
@marvin-tigera marvin-tigera merged commit 4b8ba76 into projectcalico:release-v3.22 May 11, 2022
@tomastigera tomastigera mentioned this pull request May 30, 2022
Closed
@BloodyIron BloodyIron mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

@mgleung mgleung mgleung approved these changes

Assignees
No one assigned
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Milestone
Calico v3.22.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tomastigera @mgleung @caseydavenport @marvin-tigera