Configure embed components for testing. #3163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
embed-components
branch
from
b818745 to
e5ccefb
Compare
jcoyne
reviewed
Sep 27, 2024
| @@ -123,7 +123,7 @@ def blacklight_config | |||
| config.view.embed! | |||
| # This is blacklight-gallery's openseadragon partial | |||
| unless config.view.embed.document_component | |||
| config.view.embed.partials ||= ['openseadragon'] | |||
| config.view.embed.partials ||= ['openseadragon'] unless config.view.embed.embed_component | |||
There was a problem hiding this comment.
Do we want to put something in the CatalogController template that shows the usage of embed_component?
There was a problem hiding this comment.
No. Some future version of the blacklight_gallery:install generator will do that.
cbeer
force-pushed
the
embed-components
branch
3 times, most recently
from
8951982 to
1b8da70
Compare
corylown
force-pushed
the
embed-components
branch
2 times, most recently
from
222b399 to
2b05d38
Compare
corylown
force-pushed
the
embed-components
branch
from
2b05d38 to
ea0377c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3430