Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify config.search_state_fields for Blacklight 8 #2966

Closed
Tracked by #3047
jcoyne opened this issue Mar 9, 2023 · 1 comment · Fixed by #3127
Closed
Tracked by #3047

Specify config.search_state_fields for Blacklight 8 #2966

jcoyne opened this issue Mar 9, 2023 · 1 comment · Fixed by #3127
Assignees
@marlo-longley

Comments

@jcoyne
Copy link
Member

jcoyne commented Mar 9, 2023

Blacklight 8 now sanitizes the search state parameters. So we need to ensure some parameters that Spotlight uses are allowed.

    config.search_state_fields += [:exhibit_id, :browse_category_id]
thatbudakguy added a commit to sul-dlss/dlme that referenced this issue Mar 9, 2023
@thatbudakguy
Explicitly allow browse category ID in search state
c852736 
This fixes an issue where browse categories appeared to display
all items instead of filtering to the category, because we were
not sending the browse category ID to solr. Blacklight 8 strips
out unknown params from the search unless they are specified
in config.search_state_fields.

See related projectblacklight/spotlight#2966
@thatbudakguy thatbudakguy mentioned this issue Mar 9, 2023
Merged
@corylown corylown mentioned this issue Mar 9, 2023
Closed
@corylown corylown mentioned this issue Jul 8, 2024
Open
8 tasks
@marlo-longley marlo-longley self-assigned this Sep 17, 2024
@marlo-longley marlo-longley mentioned this issue Sep 17, 2024
Merged
@marlo-longley
Copy link
Contributor

Not sure the best way to test this without being on BL8, but the code change seems straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlo-longley marlo-longley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly allow browse category ID in search state projectblacklight/spotlight
2 participants
@jcoyne @marlo-longley