-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SavedSearchesController and Blacklight::SavedSearches should be removed. #105
Comments
That sounds likely; do you want to make a PR to remove it from here? |
I'm busy on a GeoBlacklight consulting gig at the moment, but when I find some extra time I'll cook one up. Unless someone beats me to it... |
kirkkwang
added a commit
to notch8/west-virginia-university
that referenced
this issue
Dec 10, 2024
This commit will resolve some zeitwerk work issues and also remove the SavedSearchesController as it is deprecated. Ref: - projectblacklight/blacklight_advanced_search#105
kirkkwang
added a commit
to notch8/west-virginia-university
that referenced
this issue
Dec 10, 2024
This commit will resolve some zeitwerk work issues and also remove the SavedSearchesController as it is deprecated. Ref: - projectblacklight/blacklight_advanced_search#105
kirkkwang
added a commit
to notch8/west-virginia-university
that referenced
this issue
Dec 10, 2024
This commit will resolve some zeitwerk work issues and also remove the SavedSearchesController as it is deprecated. Ref: - projectblacklight/blacklight_advanced_search#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using this gem on a couple GeoBlacklight 2+ / Blacklight 7+ installs. The gem's generator adds a saved_searches_controller.rb file referencing Blacklight::SavedSearches:
https://github.com/projectblacklight/blacklight_advanced_search/blob/master/lib/generators/blacklight_advanced_search/templates/saved_searches_controller.rb
I believe Blacklight::SavedSearches was removed in BL 7... so for this gem to run correctly, you have to delete the saved_searches_controller.rb file the generator creates like so:
psu-libraries/psulib_blacklight#237
Hope this helps someone!
The text was updated successfully, but these errors were encountered: