Strip markup from html_safe selected facet values in the html title.

[seanaery]

• E.g., span/data-attributes rendered for selected range facet values by blacklight_range_limit
• Fixes span tag in html/head/title when range selected blacklight_range_limit#189

I'm not aware of cases outside of the blacklight_range_limit plugin that render markup in the selected value. However, there's a precedent for using strip_tags on the selected facet value in core in the ConstraintLayoutComponent here.

Solution in Action:

accident

[jrochkind]

I don't love how this isn't sticking to usual model of tracking whether a string is HTML or not.

Here we don't know if the string will be HTML, or possibly plain text (including non-html-safe things like angle-brackets!), but then strip_tags on it anyway. If it wasn't meant to be html and html-safe, then we may strip away things that were not meant to be stripped.

I'm not sure if there's a better solution though, this is getting convoluted.

In the specific example of the string coming from range limit, is it already html_safe?? Could strip_tags only if html_safe? that is normally a rails way of marking whether a string is a string literal or HTML code.

[seanaery]

@jrochkind Very good call -- thank you so much for looking closely and catching that. Indeed, using strip_tags like this would unintentionally turn a selected value like Six > Five into Six > Five in the title, which we would not want.

Yes, the label coming from the BlacklightRangeLimit::FacetItemPresenter is html_safe, so I'll see if I can refine this a bit.

[seanaery]

@jrochkind Thanks again for your helpful feedback on how to refine this. I have updated the PR so strip_tags would now only apply to html_safe values.