Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let a click on backdrop behind modal close the modal #3452

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Let a click on backdrop behind modal close the modal #3452

merged 1 commit into from
Dec 5, 2024

Conversation

jrochkind
Copy link
Member

The greyed out background that is NOT the modal. Match bootstrap behavior where clicking on it will close the modal.

@jrochkind
Let a click on backdrop behind modal close the modal
f9b47b1 
The greyed out background that is NOT the modal.  Match bootstrap behavior where clicking on it will close the modal.
@jrochkind
Copy link
Member Author

jrochkind commented Nov 25, 2024 •
edited
Loading

Here's how I implemented this locally in a BL 8 app, customizing BL JS to do it.

https://github.com/sciencehistory/scihist_digicoll/blob/659748a2544aa7bd2ef4b1c807ee456395bfcbbb/app/frontend/javascript/blacklight_setup.js#L52-L58

@jrochkind jrochkind merged commit 6b1d698 into main Dec 5, 2024
13 checks passed
@jrochkind jrochkind deleted the click_in_modal_backdrop_closes branch December 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bess bess bess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrochkind @bess