Set search bar border rounded class for number of configured search fields #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Nov 21, 2024
| def rounded_border_class | ||
| return 'rounded-0' if search_fields.length > 1 | ||
|
|
||
| 'rounded-left rounded-start' |
There was a problem hiding this comment.
Isn't rounded-left a bootstrap 4 class? The main branch no longer has support for Bootstrap 4.
There was a problem hiding this comment.
It is. I wasn't sure if main was still trying to support BS4. I'll change it. Thank you.
corylown
force-pushed
the
3448-search-box-border
branch
from
7e84d33 to
63b0fa4
Compare
jcoyne
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3448
With one configured search field:
Before:
After:
