Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap class to float-right rather than requiring custom css #3429

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Nov 4, 2024

No description provided.

@jcoyne jcoyne added this to the 9.X milestone Nov 4, 2024
@jrochkind
Copy link
Member

jrochkind commented Nov 4, 2024

It occurs to me that putting all this styling in as utility classes will make it harder to override locally?

But I guess this is the preferred style now?

And i guess it can prob still be over-ridden locally with !important and stuff, and/or it's easier to override the HTML locally now too?

Not sure, but it is a trade-off that came to mind. Obviously bigger than this PR -- the decision to move to replacing as much custom CSS as possible with in-dom bootstrap utility classes is previous to this PR, and I guess already made?

@jcoyne
Copy link
Member Author

jcoyne commented Nov 4, 2024

@jrochkind you could just add a class that overrides the float with .more-in-group { float: left }, now right? This is the same way you would override it now. So this just allows us to ship less css, since there's already a rule in bootstrap for this.

@jcoyne jcoyne merged commit b8f339d into main Nov 6, 2024
13 checks passed
@jcoyne jcoyne deleted the explicitly-float-right branch November 6, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants