Use a labeled <aside> for show tools sidebar #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatbudakguy
force-pushed
the
sidebar-aside
branch
from
ad7f8c3 to
68a3538
Compare
|
I don't think it actually fits the aside definition:
I don't think the facets can stand alone, they must be displayed in context of the search results. |
Is this also true of the show tools/show page sidebar, do you think? Or just search facets? |
|
@thatbudakguy I think the tools and show could arguably be an aside. |
thatbudakguy
force-pushed
the
sidebar-aside
branch
from
68a3538 to
c0bdf82
Compare
thatbudakguy
changed the title
|
Updated to only change the show page sidebar. |
jcoyne
requested changes
Nov 1, 2024
The show page sidebar is currently displayed inside a <section>; this changes it to use the <aside> element, which is arguably more appropriate for a sidebar. The search sidebar has an aria-label already set, but the show sidebar did not, which also meant that it had no accessible name despite having a landmark role. Thus this also adds a configurable aria-label for the show page sidebar similar to the one for the search sidebar.
thatbudakguy
force-pushed
the
sidebar-aside
branch
from
c0bdf82 to
eb85a74
Compare
jcoyne
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The show page sidebar is currently displayed
inside a
<section>; this changes it to use the<aside>element,which is arguably more appropriate for a sidebar.
The search sidebar had an aria-label already set, but the show
sidebar did not, which also meant that it had no accessible name
despite having a landmark role.
Thus this also adds a configurable aria-label for the show page sidebar
similar to the one for the search sidebar.