Remove styles that add unnecessary border around collapsed facets. #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
remove-unused-class
branch
from
608f825 to
2ca42c0
Compare
jcoyne
changed the title
jrochkind
approved these changes
Nov 2, 2024
jcoyne
force-pushed
the
remove-unused-class
branch
3 times, most recently
from
22d2f47 to
d99bcac
Compare
We often override this to remove these styles: https://github.com/sul-dlss/stanford-arclight/blob/a323e8108d14a9876873705ccd53a68db03c7b69/app/assets/stylesheets/sulCollection.scss#L227-L229 It would be better not to have them and let people add them if necessary.
jcoyne
force-pushed
the
remove-unused-class
branch
from
d99bcac to
00d90bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
We often override this to remove these styles:
https://github.com/sul-dlss/stanford-arclight/blob/a323e8108d14a9876873705ccd53a68db03c7b69/app/assets/stylesheets/sulCollection.scss#L227-L229
It would be better not to have them and let people add them if necessary.