Address deprecation warnings coming out of constraints #2294
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Jun 3, 2020
|
That's too bad that the BL code internally has to use a BL-depreccated method, instead of using the new one. It might be helpful for future detectives if you left a couple lines about why BL has to use deprecated method internally. |
|
It uses them internally only to provide backwards compatibility for other applications that have overridden those helpers. Once we're ready to cut a new major version, there's a bunch of places in the app where these shims get refactored away. |
|
Thanks @cbeer, makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.