Style bookmark actions as buttons, closes #2272 #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a before and after screenshot that shows the difference? |
|
Yeah! Here's without my commit:
And with my commit:
|
jcoyne
reviewed
May 12, 2020
app/views/bookmarks/_tools.html.erb
Outdated
| <%= render_show_doc_actions document_list, document: nil, document_list: @response.documents, url_opts: Blacklight::Parameters.sanitize(params.to_unsafe_h) do |config, inner| %> | ||
| <li class="nav-item"> | ||
| <button class="btn btn-outline-primary"> | ||
| <%= inner %> |
There was a problem hiding this comment.
isn't inner going to be links? I'm not sure you'd want a link in a button.
There was a problem hiding this comment.
You are totally right. I force-pushed a change to my branch to avoid this.
sandbergja
force-pushed
the
bookmark_actions_as_buttons
branch
from
4253fc2 to
fb46641
Compare
jcoyne
approved these changes
May 26, 2020
sandbergja
force-pushed
the
bookmark_actions_as_buttons
branch
from
fb46641 to
bd4293f
Compare
|
Just force-pushed a commit that uses components, rather than the (now out-of-date) original approach. |
jcoyne
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these represent actions that a user would take on their bookmarked
items, let's style them as buttons rather than nav-pills.
These actions are still wrapped in a .bookmarksTools class, just in case
anybody was using this to style their app.