Remove Saved Searches feature #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeck
approved these changes
Aug 9, 2017
|
@cbeer @jcoyne @jkeck Can anyone tell me if the actual tracking was removed from the application or just the UI for saved searches. We're seeing a really huge |
|
@mark-dce this PR doesn't stop tracking all-together. However; @mbklein submitted #1720 which can probably solve your problem. I don't have a good implementation to point to, but effectively you can configure a crawler detector that could just always return |
1 task
kosarko
added a commit
to kosarko/blacklight
that referenced
this pull request
Sep 22, 2021
I did as suggested in projectblacklight#1736 (comment) to disable search tracking, ie `config.crawler_detector = lambda { |req| true }`, but that resulted in: ``` NameError in CatalogController#index undefined local variable or method `current_user' for #<CatalogController:0x0000000000ceb8> Did you mean? current_or_guest_user Extracted source (around line projectblacklight#76): 74 def agent_is_crawler? 75 crawler_proc = blacklight_config.crawler_detector 76 return false if crawler_proc.nil? || current_user.present? 77 78 crawler_proc.call(request) 79 end Rails.root: /src/blacklightapp Application Trace | Framework Trace | Full Trace blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:76:in `agent_is_crawler?' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:41:in `find_search_session' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:32:in `current_search_session' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:37:in `set_current_search_session' activesupport (6.1.3.2) lib/active_support/callbacks.rb:427:in `block in make_lambda' ``` I've installed blacklight without devise, I have no need for users logging in, yet. The patch seems to fix the issue, it just checks something called `current_user` is defined...
bess
pushed a commit
that referenced
this pull request
Oct 21, 2021
I did as suggested in #1736 (comment) to disable search tracking, ie `config.crawler_detector = lambda { |req| true }`, but that resulted in: ``` NameError in CatalogController#index undefined local variable or method `current_user' for #<CatalogController:0x0000000000ceb8> Did you mean? current_or_guest_user Extracted source (around line #76): 74 def agent_is_crawler? 75 crawler_proc = blacklight_config.crawler_detector 76 return false if crawler_proc.nil? || current_user.present? 77 78 crawler_proc.call(request) 79 end Rails.root: /src/blacklightapp Application Trace | Framework Trace | Full Trace blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:76:in `agent_is_crawler?' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:41:in `find_search_session' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:32:in `current_search_session' blacklight (7.13.2) app/controllers/concerns/blacklight/search_context.rb:37:in `set_current_search_session' activesupport (6.1.3.2) lib/active_support/callbacks.rb:427:in `block in make_lambda' ``` I've installed blacklight without devise, I have no need for users logging in, yet. The patch seems to fix the issue, it just checks something called `current_user` is defined...
1 task
ShanaLMoore
pushed a commit
to samvera/hyku
that referenced
this pull request
Jan 8, 2024
Removes SaveSearchesController as it is not longer supported. Blacklight::SavedSearched was removed in v7+ Adds storage.yml, a required file to boot up in production. ref: - https://github.com/projectblacklight/blacklight/wiki/Saved-Searches - projectblacklight/blacklight#1736
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Feb 19, 2024
Removes SaveSearchesController as it is not longer supported. Blacklight::SavedSearched was removed in v7+ Adds storage.yml, a required file to boot up in production. ref: - https://github.com/projectblacklight/blacklight/wiki/Saved-Searches - projectblacklight/blacklight#1736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
The feature was buried in the UX and not more useful than e.g. browser bookmarks since our blacklight search urls are persistent URLs anyway.