Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct local variable for label_for_search_field and sort_field_label #1713

Merged
merged 1 commit into from
May 31, 2017
Merged

use correct local variable for label_for_search_field and sort_field_label #1713

merged 1 commit into from
May 31, 2017

Conversation

drh-stanford
Copy link

@drh-stanford drh-stanford commented May 31, 2017 •
edited
Loading

This PR corrects a NameError when these methods are called -- it cannot find the local variable/method field in these 2 methods.

NameError:
       undefined local variable or method `field' for #<#<Class:0x007fe047e32770>:0x007fe048f58270>
       Did you mean?  fields

houndci-bot
houndci-bot reviewed May 31, 2017
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_r...
/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in require': cannot load such file -- rubocop-rspec (LoadError)<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in block in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in each'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:40:in load_file'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:105:in configuration_from_file'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_store.rb:44:in for'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:93:in apply_default_formatter'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:25:in run'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:13:in block in <top (required)>'
	from /app/vendor/ruby-2.3.1/lib/ruby/2.3.0/benchmark.rb:308:in realtime'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:12:in <top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in load'<br>	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in '

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 94.373% when pulling 8c65031 on label-typos into 908c55c on master.

@drh-stanford drh-stanford mentioned this pull request May 31, 2017
Closed
@cbeer
Copy link
Member

cbeer commented May 31, 2017

Could you write a test for this case (which was apparently uncovered before?)

houndci-bot
houndci-bot reviewed May 31, 2017
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_r...
/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in require': cannot load such file -- rubocop-rspec (LoadError)<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in block in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in each'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:40:in load_file'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:105:in configuration_from_file'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_store.rb:44:in for'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:93:in apply_default_formatter'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:25:in run'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:13:in block in <top (required)>'
	from /app/vendor/ruby-2.3.1/lib/ruby/2.3.0/benchmark.rb:308:in realtime'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:12:in <top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in load'<br>	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in '

houndci-bot
houndci-bot reviewed May 31, 2017
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_r...
/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in require': cannot load such file -- rubocop-rspec (LoadError)<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:in block in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in each'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:in resolve_requires'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:40:in load_file'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:105:in configuration_from_file'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_store.rb:44:in for'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:93:in apply_default_formatter'
	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:25:in run'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:13:in block in <top (required)>'
	from /app/vendor/ruby-2.3.1/lib/ruby/2.3.0/benchmark.rb:308:in realtime'<br>	from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:12:in <top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in load'<br>	from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in '

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.377% when pulling a813173 on label-typos into ac13a35 on master.

@drh-stanford
Copy link
Author

Ok, I've added tests for those 2 methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.377% when pulling a813173 on label-typos into ac13a35 on master.

@cbeer cbeer merged commit ea75960 into master May 31, 2017
@cbeer cbeer deleted the label-typos branch May 31, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@cbeer cbeer cbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drh-stanford @coveralls @cbeer @houndci-bot