Merge pull request #2043 from projectblacklight/no-doc-id-fallback

Remove document.id fallback from document_show_link_field helper; it …
projectblacklight · Jan 4, 2019 · 4a69eba · 4a69eba
2 parents c5827f5 + c2ce208
commit 4a69eba
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/app/helpers/blacklight/configuration_helper_behavior.rb b/app/helpers/blacklight/configuration_helper_behavior.rb
@@ -163,7 +163,6 @@ def document_show_link_field document = nil
     field = fields.first if document.nil?
     field ||= fields.find { |f| document.has? f }
     field &&= field.try(:to_sym)
-    field ||= document.id
 
     field
   end

diff --git a/spec/helpers/blacklight/configuration_helper_behavior_spec.rb b/spec/helpers/blacklight/configuration_helper_behavior_spec.rb
@@ -114,12 +114,6 @@
       f = helper.document_show_link_field document
       expect(f).to eq :b
     end
-
-    it "fallbacks on the id" do
-      blacklight_config.index.title_field = [:zzz, :yyy]
-      f = helper.document_show_link_field document
-      expect(f).to eq 123
-    end
   end
 
   describe "#view_label" do