Merge pull request #3457 from projectblacklight/3456-redundant-aria-role

Remove redundant aria role from nav element
projectblacklight · Dec 4, 2024 · 38c0b58 · 38c0b58
2 parents e976f1d + 5d6e186
commit 38c0b58
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/app/components/blacklight/document_component.rb b/app/components/blacklight/document_component.rb
@@ -91,7 +91,6 @@ def initialize(document: nil, partials: nil,
                    id: nil, classes: [], component: :article, title_component: nil,
                    counter: nil, document_counter: nil, counter_offset: 0,
                    show: false, **args)
-
       @presenter = document || args[self.class.collection_parameter]
       @document = @presenter.document
       @view_partials = partials || []

diff --git a/app/components/blacklight/skip_link_component.html.erb b/app/components/blacklight/skip_link_component.html.erb
@@ -1,4 +1,4 @@
-<nav id="skip-link" role="navigation" class="visually-hidden-focusable" aria-label="<%= t('blacklight.skip_links.label') %>">
+<nav id="skip-link" class="visually-hidden-focusable" aria-label="<%= t('blacklight.skip_links.label') %>">
   <div class="container-xl">
     <%= link_to_main %>
     <%= link_to_search %>