Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search-bar): redirect to image view on enter when search maches … #422

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

laurentiuNiculae
Copy link
Contributor

…a repo:tag

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.70%. Comparing base (e2367c2) to head (2316a4c).

Files Patch % Lines
src/components/Header/SearchSuggestion.jsx 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   82.87%   82.70%   -0.17%     
==========================================
  Files          63       63              
  Lines        1880     1885       +5     
  Branches      483      485       +2     
==========================================
+ Hits         1558     1559       +1     
- Misses        311      315       +4     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…a repo:tag

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review March 1, 2024 08:02
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@andaaron andaaron merged commit 177406d into project-zot:main Mar 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants