Fixed issue #325

[Xlaits]

I affirm:

• that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
• that I've tested my code since the last commit in the PR, and will test after any later commits

[zach2good]

Congrats on your first PR, welcome to being a contributor! Just one point about commented out code and you should be good to go

[zach2good]

If these aren't being used anymore, they can just be deleted 👍

[TeoTwawki]

I think the intent was to floor at the minimum tp you could have in order to ws "just in case" some server decided to let you ws with less. I have no idea if thats even a problem but if it is I think that should be taken care of by whoever is customizing :)

[ibm2431]

And I believe it's not a necessary check either, as this function defaults to returning an ftp of 1 for invalid TP values anyway.

So I support the outright removal of the comment parts, @Xlaits ! 👍

[ibm2431]

Yep, let's remove the commented lines. Otherwise this is good!

Congratulations on your first PR~! Happy to have you here with us!

[ibm2431]

And I believe it's not a necessary check either, as this function defaults to returning an ftp of 1 for invalid TP values anyway.

So I support the outright removal of the comment parts, @Xlaits ! 👍

[ibm2431]

Pushed a commit that removed the previous commented lines! Approved.

[Xlaits]

Awesome. Forgot to remove commented code when pushing the comit initially.

…

On Tue, May 12, 2020, 12:54 PM ibm2431 ***@***.***> wrote: ***@***.**** approved this pull request. Pushed a commit that removed the previous commented lines! Approved. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#585 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHX2YDP6EO3JW562ZKWGZ73RRF5LPANCNFSM4MZARMOA> .