Added intro to teamwork questline #582
Conversation
Added three quests, intro to teamwork, intermediate teamwork, and advanced teamwork.
fixed lua style and cleaned up code
changed charVar to localVar
changed getCharVar to getLocalVar
fixed party member requirements
fixed party member requirements
| --player:startEvent(129) -- starts the ready check for all three quests | ||
| --player:startEvent(130) -- post third quest dialog | ||
| --player:startEvent(131) -- Same job | ||
| --player:startEvent(132) -- You don't have the requirements to start the second quest | ||
| --player:startEvent(133) -- Same race |
There was a problem hiding this comment.
If these events are all implemented into the script now, we no longer need the comments describing them as separate lines~! 😉
(But do keep the comments describing them when you start them later in the file 😄 )
| end | ||
| end | ||
|
|
||
| function onEventUpdate(player, csid, option) | ||
| -- csid 129 happens for both quests | ||
| if csid == 129 then |
There was a problem hiding this comment.
Is there an outgoing event option that the player selects to confirm that they're ready for the check?
There was a problem hiding this comment.
Believe it or not, both options are 0. The 'automated message' packet is what differentiates the response.
|
|
||
| -- check race for second | ||
| if (player:getRace() == tpz.race.HUME_M or player:getRace() == tpz.race.HUME_F) and (member:getRace() == tpz.race.HUME_M or member:getRace() == tpz.race.HUME_F) then |
There was a problem hiding this comment.
We could save a few CPU cycles (and line space) by assigning locals of the player's race (right after the party size requirement succeeds) and the member's race (inside the for loop), and then check those cached values in the if instead of calling member:getRace() each time:
local mRace = member:getRace()
if (pRace == tpz.race.HUME_M or pRace == tpz.race.HUME_F) and (mRace == tpz.race.HUME_M or mRace == tpz.race.HUME_F) thenFixed spacing and comments
ibm2431
added
merge ready
Added three quests, intro to teamwork, intermediate teamwork, and advanced teamwork.
I affirm: