This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
ensure trust spells are level appropriate #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
Purpose of this pull request is to ensure Trust Spells are both level appropriate and pass required checks in order to cast.
In the current implementation gambits registered with the SELECT_SPECIFIC reaction modifier will be cast regardless of level, recast timer and current MP.
This pull request adds one method to mob_spell_container (GetAvailable) in the same style as (GetBestAvailable) in order to check the trust has the spell in a spell container, has the appropriate mp to cast the spell, and the spell is currently not on cooldown.
This will still allow the trust lua files to register any needed gambits without regard to the trust level or other conditions and keep the flow as simple and straight forward as possible.
If a more appropriate method already exists rather than the new method added, I'm happy to modify the PR accordingly.