Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

FadedPromises Bastok Quest #559

Merged
merged 2 commits into from
May 7, 2020

Conversation

hooksta4
Copy link
Contributor

@hooksta4 hooksta4 commented May 1, 2020

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

@kaincenteno
Copy link
Contributor

kaincenteno commented May 1, 2020

I just did this quest 2 months ago. Seemed to work pretty well. What was changed?

@hooksta4
Copy link
Contributor Author

hooksta4 commented May 1, 2020

Not sure, I didn't see any of the stuff for that in project-topaz:release

@kaincenteno
Copy link
Contributor

you are right, sorry for the confusion, disregard my comment

@hooksta4
Copy link
Contributor Author

hooksta4 commented May 1, 2020

I was laying in bed and thought I had messed a var up and I did. I’ll update in the morning.

@ibm2431 ibm2431 changed the base branch from release to faded-promise May 5, 2020 11:57
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like your var got a little confused! 😉

end
elseif (player:getCharVar("twentyInPirateYearsCS") == 1) then
player:startEvent(261);
player:startEvent(261)
elseif (FadedPromises == QUEST_ACCEPTED and player:hasKeyItem(tpz.ki.DIARY_OF_MUKUNDA)) then
Copy link
Contributor

@ibm2431 ibm2431 May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is supposed to be checking for FadedPromises == 1...

(Because the finish sets it to 2)

elseif (csid == 803) then
player:setCharVar("FadedPromises",2)
elseif (csid == 804) then
player:setCharVar("FadedPromises",4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..and then Ayame sets it to 3 in 804...

player:startEvent(775)
elseif (player:getCharVar("BASTOK91") == 4) then
player:startEvent(776)
elseif (player:getCharVar("FadedPromises") == 4) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...And then the final check is for 3, right?

misc =
{
{
test = function(player) return player:getQuestStatus(BASTOK,tpz.quest.id.bastok.FADED_PROMISES) == QUEST_ACCEPTED and player:getCharVar("FadedPromises") == 2 and not player:hasKeyItem(tpz.ki.DIARY_OF_MUKUNDA) end,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that the test is for if the FadedPromises var is 1?

@ibm2431 ibm2431 added the hold Requests have been made to merge label May 7, 2020
@hooksta4
Copy link
Contributor Author

hooksta4 commented May 7, 2020

So that comment above that said "I was laying in bed and thought I had messed a var up and I did. I’ll update in the morning." Yea i forgot to update it. Here is the changes.

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed hold Requests have been made to merge labels May 7, 2020
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hooksta!

@zircon-tpl zircon-tpl merged commit e9d5a09 into project-topaz:faded-promise May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge ready reviewed and deemed ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants