Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Update Limbus #472

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Update Limbus #472

merged 3 commits into from
Apr 14, 2020

Conversation

cocosolos
Copy link
Contributor

@cocosolos cocosolos commented Apr 6, 2020 •
edited
Loading

  • Adjust entry requirements.
  • Overhaul limbus.lua.
  • Update Limbus NPCs.
  • Rewrite armoury crate handling.
  • Table Limbus mob/npc IDs.
  • Move soap timer from Sagheera.
  • Extend pathTo to accept pathflags.
  • Add special setup for Limbus mobs.

Note that none of the actual BCNM or mob files are adjusted here, and all zones have been locked to prevent entry.

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

TeoTwawki
TeoTwawki reviewed Apr 6, 2020
View reviewed changes
sql/npc_list.sql Outdated Show resolved Hide resolved
@cocosolos
Update Limbus
0390545 
- Adjust entry requirements.
- Overhaul limbus.lua.
- Update Limbus NPCs.
- Rewrite armoury crate handling.
- Table Limbus mob/npc IDs.
- Move soap timer from Sagheera.
- Extend pathTo to accept pathflags.
- Add special setup for Limbus mobs.
ibm2431
ibm2431 reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, cocosolos! 🙇

I'm seeing the potential for improvements being made to crates so they can be cleaner (generation, opening), but I'll bang out the code myself in a later PR. Not gonna make you worry about that noise.

Usually I make sure every line is reviewed, but I think it'll be more time efficient for me to get hands on with this updated Limbus global and the crate files while trying to "make it prettier" rather than scrolling all over the place on GitHub and typing up code comments~

Files I viewed and saw no potential problems with:
scripts/globals/battlefield.lua
scripts/zones/AlTaieu/npcs/Swirling_Vortex.lua
scripts/zones/Apollyon/IDs.lua
scripts/zones/Apollyon/Zone.lua
scripts/zones/Apollyon/npcs/Sentinel_Column.lua
scripts/zones/LaLoff_Amphitheater/IDs.lua
scripts/zones/LaLoff_Amphitheater/npcs/qm1_1.lua
scripts/zones/LaLoff_Amphitheater/npcs/qm1_2.lua
scripts/zones/LaLoff_Amphitheater/npcs/qm1_3.lua
scripts/zones/LaLoff_Amphitheater/npcs/qm1_4.lua
scripts/zones/LaLoff_Amphitheater/npcs/qm1_5.lua
scripts/zones/Temenos/IDs.lua
scripts/zones/Temenos/Zone.lua
scripts/zones/Temenos/npcs/Matter_Diffusion_Module.lua
scripts/zones/Temenos/npcs/Particle_Gate.lua
scripts/zones/Temenos/npcs/Scanning_Device.lua

Files I intend to work on later:
scripts/globals/limbus.lua
scripts/zones/Apollyon/npcs/Armoury_Crate.lua
scripts/zones/Temenos/npcs/Armoury_Crate.lua

Comments/questions on other files below.

scripts/zones/Apollyon/npcs/_127.lua Show resolved Hide resolved
src/map/utils/mobutils.cpp Outdated Show resolved Hide resolved
src/map/lua/lua_baseentity.cpp Outdated Show resolved Hide resolved
scripts/zones/Temenos/npcs/Armoury_Crate.lua Show resolved Hide resolved
scripts/zones/Temenos/npcs/Armoury_Crate.lua Show resolved Hide resolved
scripts/zones/Temenos/npcs/Armoury_Crate.lua Show resolved Hide resolved
scripts/globals/bcnm.lua Show resolved Hide resolved
scripts/zones/Port_Jeuno/npcs/Sagheera.lua Show resolved Hide resolved
@ibm2431 ibm2431 added reviewed Has been reviewed by at least one Staff Member focus Related to a current project focus labels Apr 13, 2020
ibm2431
ibm2431 approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get hands on with the Limbus global and Armory Crates when this is in a branch~

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed reviewed Has been reviewed by at least one Staff Member labels Apr 13, 2020
@ibm2431 ibm2431 changed the base branch from release to limbus April 14, 2020 22:32
@ibm2431 ibm2431 merged commit 777d8ac into project-topaz:limbus Apr 14, 2020
@cocosolos cocosolos deleted the limbus-hookup branch April 17, 2020 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TeoTwawki TeoTwawki TeoTwawki left review comments

@ibm2431 ibm2431 ibm2431 approved these changes

Assignees
No one assigned
Labels
focus Related to a current project focus merge ready reviewed and deemed ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocosolos @TeoTwawki @ibm2431