Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Upgrade !hp, !mp and !tp commands #465

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Upgrade !hp, !mp and !tp commands #465

merged 2 commits into from
Apr 11, 2020

Conversation

zach2good
Copy link
Contributor

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

I've been using this modification to these commands for a couple of weeks now and I couldn't do without them. Maybe they could be useful to others too.

Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the entered name take priority over the cursor target? I can envision someone becoming frustrated trying to get a player's stats but it failing because they were targeting something else.

@ibm2431 ibm2431 added the reviewed Has been reviewed by at least one Staff Member label Apr 7, 2020
@TeoTwawki
Copy link
Contributor

Should the entered name take priority over the cursor target? I can envision someone becoming frustrated trying to get a player's stats but it failing because they were targeting something else.

I also expect I'll accidentally heal mobs I didn't mean to.

Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordered the if a little so that the typed-in name takes priority over the current cursor target. Tested locally.

Approved. Thanks, zach!

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed reviewed Has been reviewed by at least one Staff Member labels Apr 11, 2020
@ibm2431 ibm2431 merged commit 9c990b9 into project-topaz:release Apr 11, 2020
@zach2good zach2good deleted the hp_mp_tp branch April 11, 2020 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge ready reviewed and deemed ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants