Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Add Elemental Sforzo placeholder, to make the ability usable. #464

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Add Elemental Sforzo placeholder, to make the ability usable. #464

merged 3 commits into from
Apr 11, 2020

Conversation

mrhappyasthma
Copy link
Contributor

A few things are still needed:

  1. Add enmity when cast.
  2. Update the status_effect to also protect against status effect
    spells that cause debuffs.

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

@TeoTwawki
Copy link
Contributor

spell castable

*ability usable

:)

@mrhappyasthma mrhappyasthma changed the title Add Elemental Sforzo placeholder, to make the spell castable. Add Elemental Sforzo placeholder, to make the ability usable. Apr 3, 2020
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mrhappyasthma!

Could you add the CE and VE to the abilities.sql?

Indenting should be 4 spaces; the indents here are two~

@ibm2431 ibm2431 added hold Requests have been made to merge reviewed Has been reviewed by at least one Staff Member labels Apr 8, 2020
@mrhappyasthma
Copy link
Contributor Author

Whoops. Force of habit. Will update the spacing.

Is it sufficient to just add the CE/VE to the sql file? Or do I need to apply those enmity values somewhere in code?

It seems like they will get picked up in the core and added to the spell. But I couldn't seem to find where it's applied to the player (if that's done automatically).

Any pointers would be helpful :) thanks!

@TeoTwawki
Copy link
Contributor

Is it sufficient to just add the CE/VE to the sql file? Or do I need to apply those enmity values somewhere in code?

Yep just plug into the table, core does the rest on ability use.

A few things are still needed:

1. Add enmity when cast.
2. Update the status_effect to also protect against status effect
spells that cause debuffs.
@mrhappyasthma
Copy link
Contributor Author

Updated indentation and added the CE/VE values.

Thanks for the code pointers.

Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mrhappyasthma!

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed hold Requests have been made to merge reviewed Has been reviewed by at least one Staff Member labels Apr 11, 2020
@ibm2431 ibm2431 merged commit 32b66f3 into project-topaz:release Apr 11, 2020
@ibm2431 ibm2431 linked an issue Apr 11, 2020 that may be closed by this pull request
2 tasks
@mrhappyasthma mrhappyasthma deleted the sforzo branch April 11, 2020 04:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge ready reviewed and deemed ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Elemental Sforzo to ability list
3 participants