This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
FixedPromyvions #458
Merged
FixedPromyvions #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*ALL Promyvion cutscenes now properly working according to mission progress. *Fixed player dropoff after interacting with Shattered Telepoints during 2nd Promyvion *Map acquisition now works properly in Holla and Mea
ibm2431
suggested changes
Apr 7, 2020
Comment on lines
16
to
17
| npcUtil.giveKeyItem(player, tpz.ki.MAP_OF_PROMYVION_MEA) | ||
| player:confirmTrade() |
There was a problem hiding this comment.
I know you're just using what's currently in these files, but while we're here, we might as well fix a retail inaccuracy~!
These should be starting an event where the screen flashes and there's text about blinding white lights and images being burned into your mind. This is event 49 for all three promyvions.
(And then give the KI and confirm the trade in onEventFinish for those events)
| npcUtil.giveKeyItem(player, tpz.ki.MAP_OF_PROMYVION_MEA) | ||
| player:confirmTrade() | ||
| else | ||
| player:messageSpecial(ID.text.NOTHING_HAPPENS) |
There was a problem hiding this comment.
Does this text display when you trade a bad item? Bad trades are usually just ignored.
There was a problem hiding this comment.
"Nothing happens..." is displayed on a bad trade. To my knowledge, that's correct.
ibm2431
added
merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*ALL Promyvion cutscenes now properly working according to mission progress.
*Fixed player dropoff after interacting with Shattered Telepoints during 2nd Promyvion
*Map acquisition now works properly in Holla and Mea
I affirm: