Add new bindings: getJobLevel & isJobUnlocked

[zach2good]

I affirm:

• that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
• that I've tested my code since the last commit in the PR, and will test after any later commits

As spoken about in discord, I added these to more easily support the Rhapsodies-style unlocking of the subjob with Gilgamesh's key item.

Tested with:

    print("Subjob Level: "..player:getJobLevel(0))
    print("WAR Level: "..player:getJobLevel(1))
    print("MNK Level: "..player:getJobLevel(1))
    print("DRG Level: "..player:getJobLevel(14))
    print("Subjob Unlocked: "..player:isJobUnlocked(0))
    print("WAR Unlocked: "..player:isJobUnlocked(1))
    print("MNK Unlocked: "..player:isJobUnlocked(1))
    print("DRG Unlocked: "..player:isJobUnlocked(14))

[23/Feb] [17:22:38][LUA Script] Subjob Level: 0
[23/Feb] [17:22:38][LUA Script] WAR Level: 99
[23/Feb] [17:22:38][LUA Script] MNK Level: 99
[23/Feb] [17:22:39][LUA Script] DRG Level: 0
[23/Feb] [17:22:39][LUA Script] Subjob Unlocked: 1
[23/Feb] [17:22:39][LUA Script] WAR Unlocked: 1
[23/Feb] [17:22:39][LUA Script] MNK Unlocked: 1
[23/Feb] [17:22:39][LUA Script] DRG Unlocked: 0

[ibm2431]

isJobUnlocked, jobUnlocked, or unlockedJob?

[zach2good]

Whatever you prefer?

[ibm2431]

I am horrible at deciding on function names.

I want to say that unlockedJob is the closest to natural English:
player:unlockedJob(tpz.job.WAR) -> "Player unlocked (the) job Warrior?"

But then it'd only be two characters different from unlockJob. I don't know if this is a good or bad thing.

Let's see if anyone else has very strong opinions on what it should be called!

(Bindings themselves look fine.)

[TeoTwawki]

how about hasJob() ? hasJobUnlocked()?

also technically speaking, we could just check that the job has levels. its zero if not unlocked isn't it?

[zach2good]

The reason I ended up doing two bindings is that you can't query for the level of job NON to find out if subjob is unlocked, you have to get the corresponding bit from jobs.unlocked. It felt dirty to check if the player has a subjob of any level to fulfil that condition

[TeoTwawki]

I honestly would not have thought to check eithr of these at all to find out if sub was available. Just did not cross my mind. I was like "why's his example saying subjob level when we have a binding for getting sj level?" (which is for current sj and thus not what you wanted or meant).

tl;dr I didn't get it :)

[ibm2431]

I like hasJob.