Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Added Omens Quest (BLU AF2) #361

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Added Omens Quest (BLU AF2) #361

merged 2 commits into from
Mar 26, 2020

Conversation

kaincenteno
Copy link
Contributor

Changed BEGINNINGS to check correct AF1 global
Position of flans not accurate to retail as there's no captures for a full alliance fighting BCNM
renamed blank npc to Blu_Af2 so it's easier to tell what purpose it serves.
Immortal Flans do not have any special AI or move sets that differences them from other flans.
Thank you @Wiggo32 for capturing this quest.

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

Copy link
Contributor

@KnowOne134 KnowOne134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work done. Have a few critiques before I actually test and to hear from others

scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/globals/bcnm.lua Outdated Show resolved Hide resolved
sql/npc_list.sql Outdated Show resolved Hide resolved
@zircon-tpl zircon-tpl added the focus Related to a current project focus label Feb 20, 2020
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Navukgo_Execution_Chamber/bcnms/omens.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
sql/npc_list.sql Outdated Show resolved Hide resolved
@KnowOne134 KnowOne134 added the hold Requests have been made to merge label Feb 22, 2020
@ibm2431 ibm2431 changed the base branch from master to blue-mage February 23, 2020 14:11
@ibm2431 ibm2431 self-assigned this Feb 25, 2020
@kaincenteno kaincenteno requested a review from ibm2431 February 26, 2020 03:03
Changed BEGINNINGS to check correct AF1 global
Position of flans not accurate to retail as there's no captures for a full alliance fighting BCNM
Fixed commas missing spaces after them.
Immortal Flans do not have any special AI or move sets that differences them from other flans.
Thank you Wiggo for capturing this quest.
@ibm2431 ibm2431 added the reviewed Has been reviewed by at least one Staff Member label Mar 16, 2020
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to make the flan spawning behavior accurate to retail (and some miscellaneous fixes and changes).

Approved now, sorry it took me so long to get around to this, kain!

I feel weird merging my own code without a checkmark from someone, so I'm holding off on merge until someone-other-than-me says it looks good (or next staff meeting, whichever comes first).

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed hold Requests have been made to merge reviewed Has been reviewed by at least one Staff Member labels Mar 20, 2020
@zircon-tpl zircon-tpl merged commit ecb097f into project-topaz:blue-mage Mar 26, 2020
@kaincenteno kaincenteno deleted the BLU_AF2 branch March 27, 2020 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus Related to a current project focus merge ready reviewed and deemed ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants