This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnowOne134
reviewed
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work done. Have a few critiques before I actually test and to hear from others
ibm2431
suggested changes
Feb 21, 2020
KnowOne134
reviewed
Feb 26, 2020
ibm2431
suggested changes
Feb 26, 2020
Changed BEGINNINGS to check correct AF1 global Position of flans not accurate to retail as there's no captures for a full alliance fighting BCNM Fixed commas missing spaces after them. Immortal Flans do not have any special AI or move sets that differences them from other flans. Thank you Wiggo for capturing this quest.
ibm2431
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit to make the flan spawning behavior accurate to retail (and some miscellaneous fixes and changes).
Approved now, sorry it took me so long to get around to this, kain!
I feel weird merging my own code without a checkmark from someone, so I'm holding off on merge until someone-other-than-me says it looks good (or next staff meeting, whichever comes first).
ibm2431
added
merge ready
reviewed and deemed ready to merge
and removed
hold
Requests have been made to merge
reviewed
Has been reviewed by at least one Staff Member
labels
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed BEGINNINGS to check correct AF1 global
Position of flans not accurate to retail as there's no captures for a full alliance fighting BCNM
renamed blank npc to Blu_Af2 so it's easier to tell what purpose it serves.
Immortal Flans do not have any special AI or move sets that differences them from other flans.
Thank you @Wiggo32 for capturing this quest.
I affirm: