fix: remove superfluous userxattr whiteouts #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
force-pushed
the
overlay-fix
branch
8 times, most recently
from
480d32c
to
a23be18
Compare
rchincha
force-pushed
the
overlay-fix
branch
2 times, most recently
from
d29ed6c
to
1d2e593
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
===========================================
- Coverage 57.39% 13.57% -43.83%
===========================================
Files 65 41 -24
Lines 7729 6277 -1452
===========================================
- Hits 4436 852 -3584
- Misses 2535 5292 +2757
+ Partials 758 133 -625 ☔ View full report in Codecov by Sentry. |
rchincha
force-pushed
the
overlay-fix
branch
3 times, most recently
from
21d2ddc
to
4bd914c
Compare
rchincha
force-pushed
the
overlay-fix
branch
4 times, most recently
from
d3fb761
to
a052f8f
Compare
overlayfs creates whiteout entries whenever a dir is created which is not ideal. Instead, we inspect all the lower layers and only if a dir exists, we emit a whiteout entry. Note that we link against the 'stacker' branch of project-stacker/umoci Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.