Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build for other os/arch #469

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Jun 7, 2023

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@raharper
Copy link
Contributor

Closer ...

/home/runner/work/_actions/uraimo/run-on-arch-action/v2/src/run-on-arch-commands.sh: line 25: BASE_IMAGE: unbound variable

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #469 (6fd648c) into main (8e267fc) will increase coverage by 0.02%.
Report is 40 commits behind head on main.
The diff coverage is 8.39%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   11.87%   11.89%   +0.02%     
==========================================
  Files          45       40       -5     
  Lines        5551     5733     +182     
==========================================
+ Hits          659      682      +23     
- Misses       4775     4929     +154     
- Partials      117      122       +5     
Files Coverage Δ
pkg/atomfs/molecule.go 6.08% <0.00%> (ø)
pkg/lib/file.go 51.35% <0.00%> (-2.17%) ⬇️
pkg/overlay/metadata.go 0.00% <0.00%> (ø)
pkg/stacker/grab.go 0.00% <0.00%> (ø)
pkg/squashfs/verity.go 20.73% <28.57%> (-0.55%) ⬇️
pkg/stacker/cache.go 18.28% <0.00%> (-0.32%) ⬇️
pkg/stacker/network.go 0.00% <0.00%> (ø)
pkg/stacker/import.go 0.00% <0.00%> (ø)
pkg/types/layer.go 20.51% <0.00%> (-4.19%) ⬇️
pkg/overlay/overlay.go 0.00% <0.00%> (ø)
... and 6 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants