Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showing invalid toast immediately on drop #281

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

NikhilNarayana
Copy link
Member

adds an Unvalidated state for ISOs so that we don't immediately assume the ISO is invalid and show the error

Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not a fan of calling it "Unvalidated" cuz it sounds confusing as heck but just gonna approve it for now.

@NikhilNarayana NikhilNarayana merged commit 2d1a4fe into main Feb 27, 2022
@NikhilNarayana NikhilNarayana deleted the fix/iso-validation-step branch February 27, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants