Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor defaults #187

Merged
merged 1 commit into from
Feb 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@
@Getter
@Builder
public class Defaults {

private String moneda;
private String unidadMedida;
private BigDecimal icbTasa;
private BigDecimal igvTasa;
private BigDecimal ivapTasa;
private BigDecimal icbTasa = new BigDecimal("0.5");
private BigDecimal igvTasa = new BigDecimal("0.18");
private BigDecimal ivapTasa = new BigDecimal("0.04");
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ public class UnidadDeMedidaRule extends AbstractBodyRule {

@Override
public boolean test(Object object) {
return (
isSalesDocumentItem.test(object) &&
whenSalesDocumentItem.apply(object).map(documento -> documento.getUnidadMedida() == null).orElse(false)
return (isSalesDocumentItem.test(object) && whenSalesDocumentItem.apply(object)
.map(documento -> documento.getUnidadMedida() == null)
.orElse(false)
);
}

@Override
public void modify(Object object) {
Consumer<DocumentoVentaDetalle> consumer = detalle -> detalle.setUnidadMedida(getDefaults().getUnidadMedida());
Consumer<DocumentoVentaDetalle> consumer = detalle -> detalle.setUnidadMedida("NIU");
whenSalesDocumentItem.apply(object).ifPresent(consumer);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public boolean test(Object object) {

@Override
public void modify(Object object) {
Consumer<Document> consumer = document -> document.setMoneda(getDefaults().getMoneda());
Consumer<Document> consumer = document -> document.setMoneda("PEN");
whenDocument.apply(object).ifPresent(consumer);
}
}
2 changes: 0 additions & 2 deletions core/src/test/java/e2e/AbstractTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
public class AbstractTest {

protected static final Defaults defaults = Defaults.builder()
.moneda("PEN")
.unidadMedida("NIU")
.icbTasa(new BigDecimal("0.2"))
.igvTasa(new BigDecimal("0.18"))
.ivapTasa(new BigDecimal("0.04"))
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/e2e/enricher/enrich/DetalleTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void testEnrichUnidadMedida() {
input
.getDetalles()
.forEach(detalle -> {
assertEquals(defaults.getUnidadMedida(), detalle.getUnidadMedida());
assertEquals("NIU", detalle.getUnidadMedida());
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void testEnrichMoneda() {
enricher.enrich(input);

// Then
assertEquals(defaults.getMoneda(), input.getMoneda());
assertEquals("PEN", input.getMoneda());
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,7 @@ public Template getTemplate(Type type) {

@Override
public Defaults getDefaults() {
return Defaults
.builder()
.moneda(config.moneda.orElse("PEN"))
.unidadMedida(config.unidadMedida.orElse("NIU"))
return Defaults.builder()
.igvTasa(config.igvTasa.orElse(new BigDecimal("0.18")))
.icbTasa(config.icbTasa.orElse(new BigDecimal("0.2")))
.build();
Expand Down