-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: set type_url for storage Any requests #831
Conversation
The prost protobuf library does not support message descriptors, so encapsulated Any messages from Nodes cannot fill in the type_url field. However, the C++ protobuf library code that unpacks an Any message into a specific protobuf message type requires this field to be present and match. Work around this by assuming that storage requests are of the correct type, and modify the Any message to set its type_url field appropriately.
To unblock #829 |
I was thinking to just replace that with a |
My previous feeling was that we should stick to But the latter is less relevant if we're no longer capable of filling in the (Must admit I'm slightly surprised to hear you arguing for less use of a type system though!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways let's go ahead with this to unblock things, we can follow up with the refactoring to bytes
separately.
FYI I am looking into the |
The prost protobuf library does not support message descriptors, so
encapsulated Any messages from Nodes cannot fill in the type_url
field. However, the C++ protobuf library code that unpacks an Any
message into a specific protobuf message type requires this field
to be present and match.
Work around this by assuming that storage requests are of the correct
type, and modify the Any message to set its type_url field
appropriately.
Checklist
cover any TODOs and/or unfinished work.
construction.