Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label field to Channel struct #758

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add label field to Channel struct #758

merged 1 commit into from
Mar 25, 2020

Conversation

tiziano88
Copy link
Collaborator

Will be used for enforcing Information Flow between Nodes and Channels
as part of #630.

Ref #603

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@tiziano88
Add label field to Channel struct
6996420 
Will be used for enforcing Information Flow between Nodes and Channels
as part of project-oak#630.

Ref project-oak#603
@tiziano88 tiziano88 requested a review from blaxill March 24, 2020 19:55
blaxill
blaxill approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@blaxill blaxill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tiziano88 tiziano88 merged commit fcb5550 into project-oak:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaxill blaxill blaxill approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiziano88 @blaxill @googlebot