Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oak_tests: add safety sections to doc comments #446

Merged
merged 2 commits into from
Jan 9, 2020
Merged

oak_tests: add safety sections to doc comments #446

merged 2 commits into from
Jan 9, 2020

Conversation

daviddrysdale
Copy link
Contributor

No description provided.

@daviddrysdale
Copy link
Contributor Author

Should help with #443

@daviddrysdale daviddrysdale mentioned this pull request Jan 9, 2020
Closed
tiziano88
tiziano88 reviewed Jan 9, 2020
View reviewed changes
sdk/rust/oak_tests/src/lib.rs Outdated
///
/// # Safety
///
/// The linear memory range [buf, buf+count*SPACE_BYTES_PER_HANDLE) should be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/should/must/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@daviddrysdale daviddrysdale merged commit 99b282a into project-oak:master Jan 9, 2020
@daviddrysdale daviddrysdale deleted the safe branch January 9, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddrysdale @tiziano88 @googlebot